seojangho opened a new pull request #11: [NEMO-42] Remove SchedulerTimeoutMs, Make SchedulerRunner reactive URL: https://github.com/apache/incubator-nemo/pull/11 JIRA: [NEMO-42: Remove SchedulerTimeoutMs, Make SchedulerRunner reactive](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-42) **Major changes:** - Removed `SchedulerTimeoutMs` property. - Modified SchedulerRunner to - check schedulability of all TaskGroups in PendingTaskGroupQueue in one iteration - sleep before doing next iteartion if there were no events indicating undiscovered schedulability (ExecutorAdded, TaskGroupCompleted, ...), since the start of current iteration - awake from sleep based on events indicating undiscovered schedulability - Add `PendingTaskGroupQueue#dequeueSchedulableTaskGroups` method, which dequeues multiple schedulable TaskGroups at once, to enable SchedulerRunner to check multiple TaskGroups in one iteation. - Removed awaiting mechanism in SchedulingPolicy implementaitons. Related test codes are removed too. - Modified `PendingTaskGroupQueue#dequeue` to return `Optional#empty` immediately if the queue is empty. **Minor changes to note:** - Fixed a problem that SchedulerRunner didn't schedule TaskGroups with same ScheduleGroup property in reverse-topological order. - Modified `sample_executor_resources.json` to execute integration tests with enough resources. Integration tests without enough resources are likely to hang if TaskGroups in one ScheduleGroup are scheduled in reverse-topological order. - Add `synchronized` modifier to `MetricManagerWorker#flushMetricMessageQueueToMaster` method, since this method can be invoked by multiple threads (by `scheduledExecutorService` and `MetricManagerWorker#close`) but it is not thread-safe. **Tests for the changes:** - Existing tests should cover the changes. **Other comments:** - None resolves [NEMO-42](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-42)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
