sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup
pipelining
URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r187039736
##########
File path:
compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/transform/CollectTransform.java
##########
@@ -22,44 +22,49 @@
import java.io.FileOutputStream;
import java.io.ObjectOutputStream;
import java.util.ArrayList;
-import java.util.Iterator;
+import java.util.List;
/**
* Collect transform.
* @param <T> type of data to collect.
*/
public final class CollectTransform<T> implements Transform<T, T> {
private String filename;
+ private FileOutputStream fos;
Review comment:
Why do we need to have these `fos` and `oos` as variables? It can be created
only in `close()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
