seojangho commented on a change in pull request #15: [NEMO-52] Make SchedulingPolicy Stackable URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187789065
########## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/CompositeSchedulingPolicy.java ########## @@ -0,0 +1,53 @@ +/* + * Copyright (C) 2018 Seoul National University + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package edu.snu.nemo.runtime.master.scheduler; + +import edu.snu.nemo.runtime.common.plan.physical.ScheduledTaskGroup; +import edu.snu.nemo.runtime.master.resource.ExecutorRepresenter; + +import javax.inject.Inject; +import java.util.Arrays; +import java.util.List; +import java.util.Set; + +/** + * Temporary class to implement stacked scheduling policy. + */ +public final class CompositeSchedulingPolicy implements SchedulingPolicy { + private final List<SchedulingPolicy> schedulingPolicies; + + @Inject + private CompositeSchedulingPolicy(final SourceLocationAwareSchedulingPolicy sourceLocationAwareSchedulingPolicy, + final RoundRobinSchedulingPolicy roundRobinSchedulingPolicy, + final FreeSlotSchedulingPolicy freeSlotSchedulingPolicy, + final ContainerTypeAwareSchedulingPolicy containerTypeAwareSchedulingPolicy) { + schedulingPolicies = Arrays.asList( + freeSlotSchedulingPolicy, + containerTypeAwareSchedulingPolicy, + sourceLocationAwareSchedulingPolicy, + roundRobinSchedulingPolicy); + } Review comment: This configuration should be exposed to users when Nemo begins to support job-wide execution property. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
