jeongyooneo commented on a change in pull request #5: [NEMO-27] Element Wise 
Block Write
URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r188486902
 
 

 ##########
 File path: 
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data/BlockManagerWorker.java
 ##########
 @@ -319,8 +326,7 @@ public void removeBlock(final String blockId,
                           final DataStoreProperty.Value blockStore) {
     LOG.info("RemoveBlock: {}", blockId);
     final BlockStore store = getBlockStore(blockStore);
-    final boolean exist;
-    exist = store.removeBlock(blockId);
+    final boolean exist = store.deleteBlock(blockId);
 
 Review comment:
   `exist` to `deleted`? 
   Since `deleteBlock` returns whether it successfully deleted the block.
   The term 'exist' seems confusing(the block exists after deletion?).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to