wonook commented on a change in pull request #24: [NEMO-79] Clean up the legacy
Task
URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r191671729
##########
File path:
runtime/common/src/main/java/edu/snu/nemo/runtime/common/RuntimeIdGenerator.java
##########
@@ -76,36 +79,25 @@ public static String generateStageId(final Integer
stageId) {
}
/**
- * Generates the ID for {@link
edu.snu.nemo.runtime.common.plan.physical.Task}.
- *
- * @param irVertexId the ID of the IR vertex.
- * @return the generated ID
- */
- public static String generateLogicalTaskId(final String irVertexId) {
- return "Task-" + irVertexId;
- }
-
- /**
- * Generates the ID for {@link
edu.snu.nemo.runtime.common.plan.physical.Task}.
+ * Generates the ID for the physical representation of an IRVertex.
*
- * @param index the index of the physical task.
- * @param logicalTaskId the logical ID of the task.
+ * @param irVertexId the id of the IRVertex.
+ * @param index the index of the physical task.
* @return the generated ID
*/
- public static String generatePhysicalTaskId(final int index,
- final String logicalTaskId) {
- return logicalTaskId + PHYSICAL_TASK_ID_SPLITTER + index;
+ public static String generatePhysicalIRVertexId(final String irVertexId,
Review comment:
As far as I understand, this PR gets rid of the Tasks in runtime, and
replaces it with the original IR vertices, which previous tasks have been
referring to. However, this method creates ID for the Physical IR vertex which
I'm unsure of its purpose. I think there should be rather a _Physical Vertex_
or something else and make it different from the original IR vertex, if it is
not going to be used as it is used in the IR. Please check this part throughout
the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
