jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the
legacy Task
URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r192005437
##########
File path: common/src/main/java/edu/snu/nemo/common/ir/vertex/SourceVertex.java
##########
@@ -34,4 +34,9 @@
* @throws Exception if fail to get.
*/
public abstract List<Readable<O>> getReadables(int desiredNumOfSplits)
throws Exception;
+
+ /**
+ * Clears internal states, must be called after getReadables().
Review comment:
Could you add the following description in this comment too?
Since the meaning and context of 'internal states' of `SourceVertex` isn't
clear by itself.
> Adds SourceVertex#clearInternalStates to clear the huge list of input
splits held by BeamBoundedSourceVertex before sending the vertex to remote
executors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
