jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed
executor with a new executor
URL: https://github.com/apache/incubator-nemo/pull/27#discussion_r192946662
##########
File path: runtime/driver/src/main/java/edu/snu/nemo/driver/NemoDriver.java
##########
@@ -153,13 +153,7 @@ private void startSchedulingUserApplication() {
public final class FailedEvaluatorHandler implements
EventHandler<FailedEvaluator> {
@Override
public void onNext(final FailedEvaluator failedEvaluator) {
- // The list size is 0 if the evaluator failed before an executor
started. For now, the size is 1 otherwise.
- failedEvaluator.getFailedContextList().forEach(failedContext -> {
Review comment:
Is it necessary to move this code(getteing failed context list) to
`RuntimeMaster`? Since handling `FailedEvaluator` belongs to REEF evaluator
part.
If there's any specific reason, could you explain it in comments at
`RuntimeMaster`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
