wonook commented on a change in pull request #28: [NEMO-12] Frontend support
for Scala Spark
URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193641579
##########
File path:
compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/Dataset.java
##########
@@ -73,6 +74,24 @@ private Dataset(final SparkSession sparkSession, final
LogicalPlan logicalPlan,
return JavaRDD.of((SparkSession) super.sparkSession(), this);
}
+ /**
+ * @return a Spark RDD from this dataset.
+ */
+ public org.apache.spark.rdd.RDD<T> sparkRDD() {
Review comment:
[This](https://stackoverflow.com/questions/4595512/java-calling-a-super-method-which-calls-an-overridden-method)
is the link to what I was worried about when I first saw this part of the
code. Please double-check if this wouldn't affect or confuse users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
