sanha commented on a change in pull request #30: [NEMO-63] On-demand dynamic 
optimization metric aggregation
URL: https://github.com/apache/incubator-nemo/pull/30#discussion_r194611505
 
 

 ##########
 File path: 
common/src/main/java/edu/snu/nemo/common/ir/vertex/MetricCollectionBarrierVertex.java
 ##########
 @@ -29,7 +29,9 @@
  */
 public final class MetricCollectionBarrierVertex<T> extends IRVertex {
   // Partition ID to Size data
 
 Review comment:
   BTW, why don't we change it to task ID? Block ID seems quite tied to our 
current data skew handling example.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to