seojangho commented on a change in pull request #48: [NEMO-72] Instance-based Encoder/Decoder interface URL: https://github.com/apache/incubator-nemo/pull/48#discussion_r196275302
########## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data/SerializerManager.java ########## @@ -15,23 +15,22 @@ */ package edu.snu.nemo.runtime.executor.data; -import edu.snu.nemo.runtime.executor.data.streamchainer.CompressionStreamChainer; -import edu.snu.nemo.runtime.executor.data.streamchainer.StreamChainer; -import edu.snu.nemo.common.coder.Coder; +import edu.snu.nemo.common.coder.Decoder; +import edu.snu.nemo.common.coder.Encoder; +import edu.snu.nemo.runtime.executor.data.streamchainer.*; import edu.snu.nemo.common.ir.edge.executionproperty.CompressionProperty; -import edu.snu.nemo.runtime.executor.data.streamchainer.Serializer; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import javax.annotation.Nullable; import javax.inject.Inject; import java.util.ArrayList; -import java.util.Collections; import java.util.List; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; /** - * Mapping from RuntimeEdgeId to Coder. + * Mapping from RuntimeEdgeId to Encoder. Review comment: `Encoder/Decoder` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
