seojangho closed pull request #58: [NEMO-133] Remove run_external_app.sh
URL: https://github.com/apache/incubator-nemo/pull/58
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 79a41659..d7b1db83 100644
--- a/README.md
+++ b/README.md
@@ -64,18 +64,6 @@ Please refer to the [Contribution 
guideline](.github/CONTRIBUTING.md) to contrib
 * Run only unit tests and install: `mvn clean install -DskipITs -T 2C`
 
 ## Running Beam applications
-### Running an external Beam application
-* Use run_external_app.sh instead of run.sh
-* Set the first argument the path to the external Beam application jar
-
-```bash
-./bin/run_external_app.sh \
-    `pwd`/nemo_app/target/bd17f-1.0-SNAPSHOT.jar \
-    -job_id mapreduce \
-    -executor_json `pwd`/examples/resources/sample_executor_resources.json \
-    -user_main MapReduce \
-    -user_args "`pwd`/mr_input_data `pwd`/nemo_output/output_data"
-```
 
 ### Configurable options
 * `-job_id`: ID of the Beam job
diff --git a/bin/run_external_app.sh b/bin/run_external_app.sh
deleted file mode 100755
index 5a959353..00000000
--- a/bin/run_external_app.sh
+++ /dev/null
@@ -1,20 +0,0 @@
-#!/usr/bin/env bash
-#
-# Copyright (C) 2018 Seoul National University
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#         http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-parent_path=$( cd "$(dirname "${BASH_SOURCE[0]}")" ; pwd -P )
-pushd $parent_path
-java -cp examples/target/nemo-examples-0.1-SNAPSHOT-shaded.jar:$1:`yarn 
classpath` edu.snu.nemo.client.JobLauncher "${@:2}"
-popd


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to