seojangho commented on issue #60: [NEMO-61] Fix lost execution metric collection problem URL: https://github.com/apache/incubator-nemo/pull/60#issuecomment-401248156 Thanks for the work @skystar-p! I've done a quick pass for the changes. In my humble opinion, MetricManagerMaster should be responsible for sending flush requests to MetricManagerWorkers. Then, for writing tests we only have to inject MetricManagerMaster and MetricManagerWorkers, rather than RuntimeMaster. (which is quite huge!)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
