wonook commented on a change in pull request #60: [NEMO-61] Fix lost execution
metric collection problem
URL: https://github.com/apache/incubator-nemo/pull/60#discussion_r199060033
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/Executor.java
##########
@@ -161,12 +161,21 @@ public void terminate() {
@Override
public void onMessage(final ControlMessage.Message message) {
switch (message.getType()) {
- case ScheduleTask:
- final ControlMessage.ScheduleTaskMsg scheduleTaskMsg =
message.getScheduleTaskMsg();
- final Task task =
-
SerializationUtils.deserialize(scheduleTaskMsg.getTask().toByteArray());
- onTaskReceived(task);
- break;
+ case ScheduleTask:
+ final ControlMessage.ScheduleTaskMsg scheduleTaskMsg =
message.getScheduleTaskMsg();
+ final Task task =
+
SerializationUtils.deserialize(scheduleTaskMsg.getTask().toByteArray());
+ onTaskReceived(task);
+ break;
+ case RequestMetricFlush:
+ metricMessageSender.flush();
+
persistentConnectionToMasterMap.getMessageSender(MessageEnvironment.RUNTIME_MASTER_MESSAGE_LISTENER_ID).send(
+ ControlMessage.Message.newBuilder()
+ .setId(RuntimeIdGenerator.generateMessageId())
+
.setListenerId(MessageEnvironment.RUNTIME_MASTER_MESSAGE_LISTENER_ID)
+ .setType(ControlMessage.MessageType.MetricFlushed)
+ .build());
+ break;
default:
Review comment:
This is the line I'm talking about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
