seojangho commented on a change in pull request #67: [NEMO-54] Handle remote
data fetch failures due to executor removal
URL: https://github.com/apache/incubator-nemo/pull/67#discussion_r199696813
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/task/ParentTaskDataFetcher.java
##########
@@ -127,16 +125,37 @@ Object fetchDataElement() throws IOException {
return null;
}
} else {
+ // Advance to the next one
handleMetric(currentIterator);
- // Try the next iterator
- this.currentIteratorIndex += 1;
- this.currentIterator = dataQueue.take();
+ advanceIterator();
return fetchDataElement();
}
}
- } catch (InterruptedException exception) {
- Thread.currentThread().interrupt();
- throw new IOException(exception);
+ } catch (Throwable e) {
Review comment:
`final Throwable e`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
