wynot12 commented on a change in pull request #73: [Nemo-62] Support Multiple
Jobs Submission in a Single User Program
URL: https://github.com/apache/incubator-nemo/pull/73#discussion_r201417206
##########
File path: client/src/main/java/edu/snu/nemo/client/JobLauncher.java
##########
@@ -118,22 +153,39 @@ public static void main(final String[] args) throws
Exception {
*/
// When modifying the signature of this method, see
CompilerTestUtil#compileDAG and make corresponding changes
public static void launchDAG(final DAG dag) {
Review comment:
You assume that `launchDAG` method is never invoked concurrently.
You assume that the user application submits 'DAG' one by one after the
previous one has finished.
Could you please specify this assumption in JavaDoc?
I'm curious whether it's okay not to support asynchronous DAG submissions by
(multiple) user application(s).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
