sanha opened a new pull request #74: [NEMO-141] Make vertices receiving push 
edge not comply executor slot
URL: https://github.com/apache/incubator-nemo/pull/74
 
 
   JIRA: [NEMO-141: Make vertices receiving push edge not comply executor 
slot](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-141)
   
   **Major changes:**
   - Make relay vertices added by `SailfishPass` not comply executor slot 
constraint.
   - Make `FreeSlotSchedulingConstraint` does not count tasks with `false` slot 
compliance value while calculating running tasks.
   
   **Minor changes to note:**
   - Make `FreeSlotSchedulingConstraint` be constructed through Tang only.
   
   **Tests for the changes:**
   - `FreeSlotSchedulingConstraintTest` is updated to handle added cases.
   - Reduced the capacity of the single executor in `testSailfishInOneExecutor` 
to 2. Because the number of relay tasks receiving push edge is 2, this test 
does not run without the new features added in this pr.
   
   **Other comments:**
   - I considered to make all vertices that receive any push edge not comply 
the slot constraint, but decide to not due to a staging issue. If we make the 
slot compliance value of a single vertex as false, the vertex becomes a single 
stage because of different execution property.
   
   resolves 
[NEMO-141](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-141)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to