wonook commented on a change in pull request #73: [NEMO-62] Support Multiple
Jobs Submission in a Single User Program
URL: https://github.com/apache/incubator-nemo/pull/73#discussion_r203606886
##########
File path: client/src/main/java/edu/snu/nemo/client/JobLauncher.java
##########
@@ -78,16 +84,14 @@ private JobLauncher() {
* @throws Exception exception on the way.
*/
public static void main(final String[] args) throws Exception {
- final DriverRPCServer driverRPCServer = new DriverRPCServer();
+ driverRPCServer = new DriverRPCServer();
+
// Registers actions for launching the DAG.
driverRPCServer
.registerHandler(ControlMessage.DriverToClientMessageType.DriverStarted, event
-> { })
-
.registerHandler(ControlMessage.DriverToClientMessageType.ResourceReady, event
->
-
driverRPCServer.send(ControlMessage.ClientToDriverMessage.newBuilder()
- .setType(ControlMessage.ClientToDriverMessageType.LaunchDAG)
-
.setLaunchDAG(ControlMessage.LaunchDAGMessage.newBuilder().setDag(serializedDAG).build())
- .build()))
-
.registerHandler(ControlMessage.DriverToClientMessageType.DataCollected,
message -> collectedData.addAll(
+
.registerHandler(ControlMessage.DriverToClientMessageType.ResourceReady, event
-> driverReadyLatch.countDown())
Review comment:
I'll rename it to DriverReady. I tried to follow what was already there, but
I think it would be better to make the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
