jeongyooneo commented on a change in pull request #84: [NEMO-171] Fix confusing
ITCase input/output file names
URL: https://github.com/apache/incubator-nemo/pull/84#discussion_r207774259
##########
File path: examples/spark/src/test/java/edu/snu/nemo/examples/spark/MRJava.java
##########
@@ -61,16 +61,16 @@ public void testSparkWordCount() throws Exception {
.build());
try {
- ExampleTestUtil.ensureOutputValidity(fileBasePath, outputFileName,
testResourceFilename);
+ ExampleTestUtil.ensureOutputValidity(fileBasePath, outputFileName,
expectedOutputFilename);
} finally {
ExampleTestUtil.deleteOutputFile(fileBasePath, outputFileName);
}
}
/* TODO #152: enable execution of multiple jobs (call scheduleJob multiple
times with caching).
@Test(timeout = TIMEOUT)
public void testSparkWordAndLineCount() throws Exception {
- final String inputFileName = "sample_input_wordcount_spark";
- final String outputFileName = "sample_output_word_and_line_count";
+ final String inputFileName = "test_input_wordcount_spark";
+ final String outputFileName = "test_output_word_and_line_count";
final String testResourceFilename = "test_output_word_and_line_count";
Review comment:
`outputFilename` and `testResourceFilename` became the same!
Maybe `testResourceFilename` to `expectedOutputFilename` as above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
