johnyangk commented on a change in pull request #85: [NEMO-172] Implement one partition per one element partitioner URL: https://github.com/apache/incubator-nemo/pull/85#discussion_r208069498
########## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data/partitioner/DedicatedKeyPerElementPartitioner.java ########## @@ -0,0 +1,38 @@ +/* + * Copyright (C) 2018 Seoul National University + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package edu.snu.nemo.runtime.executor.data.partitioner; + +import java.util.concurrent.atomic.AtomicInteger; + +/** + * An implementation of {@link Partitioner} which assigns a dedicated key per an output data from a task. + */ +@DedicatedKeyPerElement +public final class DedicatedKeyPerElementPartitioner implements Partitioner<Integer> { + private final AtomicInteger key; + + /** + * Constructor. + */ + public DedicatedKeyPerElementPartitioner() { + this.key = new AtomicInteger(); + } + + @Override + public Integer partition(final Object element) { + return key.getAndIncrement(); Review comment: Can you comment on the rationale for assigning a distinct integer key for each element? With this approach, two same elements can be assigned to different keys. Is that intentional? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
