johnyangk commented on a change in pull request #89: [NEMO-175] Remove
'taskInfo', add Scheduler#completeHeldTask
URL: https://github.com/apache/incubator-nemo/pull/89#discussion_r208134965
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJobScheduler.java
##########
@@ -124,14 +124,16 @@ public void scheduleJob(final PhysicalPlan
physicalPlanOfJob, final JobStateMana
}
@Override
- public void updateJob(final String jobId, final PhysicalPlan
newPhysicalPlan, final Pair<String, String> taskInfo) {
+ public void updateJob(final String jobId, final PhysicalPlan
newPhysicalPlan) {
// update the job in the scheduler.
// NOTE: what's already been executed is not modified in the new physical
plan.
this.physicalPlan = newPhysicalPlan;
- if (taskInfo != null) {
- onTaskExecutionComplete(taskInfo.left(), taskInfo.right(), true);
- doSchedule();
- }
+ }
+
+ @Override
+ public void completeHeldTask(final String taskId, final String executorId) {
+ onTaskExecutionComplete(executorId, taskId, true);
Review comment:
Unfortunately this method has a problem of not doing anything when
`isOnHoldToComplete=true`. It may be better for this method to be called only
when the state changes to COMPLETE, but not when the state changes to ON_HOLD.
Sorry about this, I've had an eye on this for a while, but never really had the
chance to fix the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
