johnyangk commented on a change in pull request #91: [NEMO-3] Bump up the Beam
version to 2.5.0
URL: https://github.com/apache/incubator-nemo/pull/91#discussion_r208197324
##########
File path:
compiler/frontend/beam/src/main/java/edu/snu/nemo/compiler/frontend/beam/transform/CreateViewTransform.java
##########
@@ -77,4 +99,28 @@ public String toString() {
sb.append("CreateViewTransform:" + pCollectionView);
return sb.toString();
}
+
+ /**
+ * Represents {@code PrimitiveViewT} supplied to the {@link ViewFn}.
+ * @param <T> primitive view type
+ */
+ public final class MultiView<T> implements
Materializations.MultimapView<Void, T>, Serializable {
+ private final ArrayList<T> dataList;
+
+ /**
+ * Constructor.
+ */
+ MultiView() {
+ dataList = new ArrayList<>();
Review comment:
new ArrayList<>(0);
Also comment here why we're using an empty list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
