johnyangk commented on a change in pull request #88: [NEMO-138] Rule-based
policy
URL: https://github.com/apache/incubator-nemo/pull/88#discussion_r208202496
##########
File path:
compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/CompileTimePass.java
##########
@@ -19,19 +19,21 @@
import edu.snu.nemo.common.ir.vertex.IRVertex;
import edu.snu.nemo.common.dag.DAG;
import edu.snu.nemo.common.ir.executionproperty.ExecutionProperty;
+import edu.snu.nemo.common.pass.Pass;
import java.io.Serializable;
import java.util.Set;
import java.util.function.Function;
/**
- * Interface for compile-time optimization passes that processes the DAG.
+ * Abstract class for compile-time optimization passes that processes the DAG.
* It is a function that takes an original DAG to produce a processed DAG,
after an optimization.
*/
-public interface CompileTimePass extends Function<DAG<IRVertex, IREdge>,
DAG<IRVertex, IREdge>>, Serializable {
+public abstract class CompileTimePass extends Pass
+ implements Function<DAG<IRVertex, IREdge>, DAG<IRVertex, IREdge>>,
Serializable {
Review comment:
drop `Serializable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
