seojangho commented on a change in pull request #94: [NEMO-152] Support Multiple DAGs Execution in a Single User Program URL: https://github.com/apache/incubator-nemo/pull/94#discussion_r208795793
########## File path: compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/policy/Policy.java ########## @@ -20,13 +20,15 @@ import edu.snu.nemo.common.ir.edge.IREdge; import edu.snu.nemo.common.ir.vertex.IRVertex; import org.apache.reef.tang.Injector; +import org.apache.reef.tang.annotations.DefaultImplementation; import java.io.Serializable; /** * An interface for policies, each of which is composed of a list of static optimization passes. * The list of static optimization passes are run in the order provided by the implementation. */ +@DefaultImplementation(PolicyImpl.class) Review comment: Do we need this? PolicyImpl is not even an injectable class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
