sanha commented on a change in pull request #102: [NEMO-180] Java Annotation 
for Prerequisite Execution Properties
URL: https://github.com/apache/incubator-nemo/pull/102#discussion_r210849087
 
 

 ##########
 File path: 
compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/annotating/DecompressionPass.java
 ##########
 @@ -26,13 +26,14 @@
  * A pass for applying decompression algorithm for data flowing between 
vertices.
  * It always
  */
+@Annotates(CompressionProperty.class)
 public final class DecompressionPass extends AnnotatingPass {
 
   /**
    * Constructor.
    */
   public DecompressionPass() {
-    super(CompressionProperty.class);
+    super(DecompressionPass.class);
   }
 
 
 Review comment:
   It seems that this pass requires `CompressionProperty`. Why don't we add the 
property to `Requires` annotation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to