johnyangk commented on issue #109: [NEMO-89] Clean up IRVertex#getClone() URL: https://github.com/apache/incubator-nemo/pull/109#issuecomment-414170810 @arunlakshman Good catch. I suppose we should create a new ID while cloning the vertex for the reasons below. 1. Each IRVertex should have a unique id within its DAG, including the clones. 2. We're using `getClone` in `LoopVertex#unRollIteration` to effectively generate clones of loops. I'll update the JIRA issue accordingly to use new IDs for clones. I suppose the integrity checker in `DAGBuilder` should also check for duplicate ids catch these errors. I'll file a JIRA for that as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
