sanha commented on a change in pull request #111: [NEMO-139, 6] Logic in the scheduler for appending jobs, Support RDD caching URL: https://github.com/apache/incubator-nemo/pull/111#discussion_r211445717
########## File path: common/src/main/java/edu/snu/nemo/common/ir/edge/executionproperty/CacheIDProperty.java ########## @@ -0,0 +1,44 @@ +/* + * Copyright (C) 2018 Seoul National University + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package edu.snu.nemo.common.ir.edge.executionproperty; + +import edu.snu.nemo.common.ir.executionproperty.EdgeExecutionProperty; + +import java.util.UUID; + +/** + * Cache ID ExecutionProperty. + */ +public final class CacheIDProperty extends EdgeExecutionProperty<UUID> { Review comment: In my thought, it would be good to separate them because the `PersistenceProperty` can be used to change the persistence itself but not for caching. For example, our large shuffle optimization change the persistence to conduct shuffle on memory. If we merge the cache ID with the persistence property, the `Pass` developer should decide to maintain or discard the cache ID or not while modifying the `PersistenceProperty`.. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
