sanha commented on a change in pull request #112: [NEMO-179] Delayed Task Cloning URL: https://github.com/apache/incubator-nemo/pull/112#discussion_r211817451
########## File path: compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/annotating/UpfrontCloningPass.java ########## @@ -20,11 +20,12 @@ import edu.snu.nemo.common.ir.edge.executionproperty.CommunicationPatternProperty; import edu.snu.nemo.common.ir.vertex.IRVertex; import edu.snu.nemo.common.ir.vertex.executionproperty.ClonedSchedulingProperty; +import edu.snu.nemo.compiler.optimizer.pass.compiletime.Requires; /** * Set the ClonedScheduling property of source vertices, in an upfront manner. */ -@Annotates(ClonedSchedulingProperty.class) +@Requires(ClonedSchedulingProperty.class) Review comment: It requires `CommunicationPatternProperty` and annotates `ClonedSchedulingProperty` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
