sanha commented on a change in pull request #113: [NEMO-15] Run Spark ALS in distributed mode URL: https://github.com/apache/incubator-nemo/pull/113#discussion_r214245130
########## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/InMasterBroadcastVariables.java ########## @@ -0,0 +1,43 @@ +/* + * Copyright (C) 2018 Seoul National University + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package edu.snu.nemo.runtime.master; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Serializable; +import java.util.HashMap; +import java.util.Map; + +/** + * Broadcast variables saved in the master. + */ +public final class InMasterBroadcastVariables { + private static final Logger LOG = LoggerFactory.getLogger(InMasterBroadcastVariables.class.getName()); + + private static final Map<Serializable, Object> TAG_TO_VARIABLE = new HashMap<>(); + + private InMasterBroadcastVariables() { + } + + public static void registerBroadcastVariablesFromClient(final Map<Serializable, Object> variables) { Review comment: Please add some comments for these public methods. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
