seojangho commented on a change in pull request #114: [NEMO-203] Beam SQL
Aggregation fails to match RowCoder in Combine transform
URL: https://github.com/apache/incubator-nemo/pull/114#discussion_r214564159
##########
File path:
compiler/frontend/beam/src/main/java/edu/snu/nemo/compiler/frontend/beam/PipelineTranslator.java
##########
@@ -326,6 +388,10 @@ private TranslationContext(final CompositeTransformVertex
pipeline,
this.pipelineOptions = pipelineOptions;
}
+ public CompositeTransformVertex getPipeline() {
Review comment:
Do we really need this 'public' method? PipelineTranslator is a function
that takes a pipeline and emits the corresponding IR. PipelineTranslator users
do not have to rely on this method to obtian the pipeline, becuase it already
has the pipeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
