johnyangk commented on a change in pull request #122: [NEMO-213] Use Beam's
DoFnRunners to execute DoFn
URL: https://github.com/apache/incubator-nemo/pull/122#discussion_r223657596
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/PipelineTranslator.java
##########
@@ -169,7 +240,7 @@ private static void windowTranslator(final
TranslationContext ctx,
} else {
throw new UnsupportedOperationException(String.format("%s is not
supported", transform));
}
- final IRVertex vertex = new OperatorVertex(new WindowTransform(windowFn));
+ final IRVertex vertex = new OperatorVertex(new
WindowDoFnTransform(windowFn));
Review comment:
Can we use the existing name `WindowTransform`?
Beam's `WindowFn` doesn't seem to extend `DoFn`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
