johnyangk commented on a change in pull request #122: [NEMO-213] Use Beam's
DoFnRunners to execute DoFn
URL: https://github.com/apache/incubator-nemo/pull/122#discussion_r223665761
##########
File path:
examples/beam/src/main/java/org/apache/nemo/examples/beam/MultinomialLogisticRegression.java
##########
@@ -225,7 +227,7 @@ public void processElement(final ProcessContext c) throws
Exception {
@FinishBundle
public void finishBundle(final FinishBundleContext c) {
for (Integer i = 0; i < gradients.size(); i++) {
- c.output(KV.of(i, gradients.get(i)), null, null);
+ c.output(KV.of(i, gradients.get(i)),
BoundedWindow.TIMESTAMP_MIN_VALUE, GlobalWindow.INSTANCE);
Review comment:
Please add a note here that this enforces a global window (batching), where
all data elements of the corresponding PCollection are grouped and emitted
downstream together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
