johnyangk commented on a change in pull request #128: [NEMO-235] Refactor
TaskExecutor's data processing logic
URL: https://github.com/apache/incubator-nemo/pull/128#discussion_r228010677
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/task/TaskExecutor.java
##########
@@ -634,11 +502,12 @@ private void finalizeOutputWriters(final VertexHarness
vertexHarness) {
});
// finalize OutputWriters for additional tagged children
-
vertexHarness.getWritersToAdditionalChildrenTasks().values().forEach(outputWriter
-> {
- outputWriter.close();
-
- final Optional<Long> writtenBytes = outputWriter.getWrittenBytes();
- writtenBytes.ifPresent(writtenBytesList::add);
+
vertexHarness.getWritersToAdditionalChildrenTasks().values().forEach(outputWriters
-> {
+ outputWriters.forEach(outputWriter -> {
Review comment:
How about closing OutputWriters in OutputCollector.close, and removing
OutputWriters from VertexHarness?
i.e., remove (1) and use only (2)
(1) VertexHarness -> OutputWriters
(2) VertexHarness -> OutputCollector -> OutputWriters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
