johnyangk commented on a change in pull request #152: [NEMO-268] Consider
start/finish bundles in Transform
URL: https://github.com/apache/incubator-nemo/pull/152#discussion_r231366148
##########
File path:
compiler/test/src/test/java/org/apache/nemo/compiler/frontend/beam/transform/DoFnTransformTest.java
##########
@@ -90,6 +92,97 @@ public void testSingleOutput() {
doFnTransform.close();
}
+
+ @Test
+ @SuppressWarnings("unchecked")
+ public void testCountBundle() {
+
+ final TupleTag<String> outputTag = new TupleTag<>("main-output");
+ final NemoPipelineOptions pipelineOptions =
PipelineOptionsFactory.as(NemoPipelineOptions.class);
+ pipelineOptions.setMaxBundleSize(3L);
+ pipelineOptions.setMaxBundleTimeMills(10000000L);
+
+ final List<Integer> bundleOutput = new ArrayList<>();
+
+ final DoFnTransform<String, String> doFnTransform =
+ new DoFnTransform<>(
+ new BundleTestDoFn(bundleOutput),
+ NULL_INPUT_CODER,
+ NULL_OUTPUT_CODERS,
+ outputTag,
+ Collections.emptyList(),
+ WindowingStrategy.globalDefault(),
+ emptyList(), /* side inputs */
+ pipelineOptions);
+
+ final Transform.Context context = mock(Transform.Context.class);
+ final OutputCollector<WindowedValue<String>> oc = new
TestOutputCollector<>();
+ doFnTransform.prepare(context, oc);
+
+ doFnTransform.onData(WindowedValue.valueInGlobalWindow("a"));
+ doFnTransform.onData(WindowedValue.valueInGlobalWindow("a"));
+ doFnTransform.onData(WindowedValue.valueInGlobalWindow("a"));
+
+ assertEquals(3, (int) bundleOutput.get(0));
+
+ bundleOutput.clear();
+
+ doFnTransform.onData(WindowedValue.valueInGlobalWindow("a"));
+ doFnTransform.onData(WindowedValue.valueInGlobalWindow("a"));
+ doFnTransform.onData(WindowedValue.valueInGlobalWindow("a"));
+
+ assertEquals(3, (int) bundleOutput.get(0));
+
+ doFnTransform.close();
+ }
+
+ @Test
+ @SuppressWarnings("unchecked")
+ public void testTimeBundle() {
+
+ final long maxBundleTimeMills = 1000L;
+ final TupleTag<String> outputTag = new TupleTag<>("main-output");
+ final NemoPipelineOptions pipelineOptions =
PipelineOptionsFactory.as(NemoPipelineOptions.class);
+ pipelineOptions.setMaxBundleSize(10000000L);
+ pipelineOptions.setMaxBundleTimeMills(maxBundleTimeMills);
+
+ final List<Integer> bundleOutput = new ArrayList<>();
+
+ final DoFnTransform<String, String> doFnTransform =
+ new DoFnTransform<>(
+ new BundleTestDoFn(bundleOutput),
+ NULL_INPUT_CODER,
+ NULL_OUTPUT_CODERS,
+ outputTag,
+ Collections.emptyList(),
+ WindowingStrategy.globalDefault(),
+ emptyList(), /* side inputs */
+ pipelineOptions);
+
+ final Transform.Context context = mock(Transform.Context.class);
+ final OutputCollector<WindowedValue<String>> oc = new
TestOutputCollector<>();
+
+ long startTime = System.currentTimeMillis();
+ doFnTransform.prepare(context, oc);
+
+ int count = 0;
+ while (bundleOutput.isEmpty()) {
+ doFnTransform.onData(WindowedValue.valueInGlobalWindow("a"));
+ count += 1;
+ try {
+ Thread.sleep(10);
+ } catch (InterruptedException e) {
+ e.printStackTrace();
Review comment:
throw new RuntimeException(e)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
