taegeonum commented on a change in pull request #159: [NEMO-216,251,259] Support side inputs and windowing URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r234427549
########## File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/MaterializedViewReader.java ########## @@ -16,48 +16,55 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.nemo.compiler.frontend.beam.transform; +package org.apache.nemo.compiler.frontend.beam; -import org.apache.beam.runners.core.SideInputReader; +import org.apache.beam.runners.core.ReadyCheckingSideInputReader; import org.apache.beam.sdk.transforms.windowing.BoundedWindow; import org.apache.beam.sdk.util.WindowedValue; import org.apache.beam.sdk.values.PCollectionView; -import org.apache.nemo.common.ir.vertex.transform.Transform; +import org.apache.nemo.common.Pair; import javax.annotation.Nullable; -import java.util.Collection; +import java.util.HashMap; +import java.util.List; +import java.util.Map; /** - * A sideinput reader that reads/writes side input values to context. Review comment: Please add comments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
