johnyangk commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r235279915
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/AbstractDoFnTransform.java
##########
@@ -132,10 +145,14 @@ public final DoFn getDoFn() {
* Checks whether the bundle is finished or not.
* Starts the bundle if it is done.
*/
- protected final void checkAndInvokeBundle() {
+ final void checkAndInvokeBundle() {
if (bundleFinished) {
bundleFinished = false;
- doFnRunner.startBundle();
+ if (pushBackRunner == null) {
Review comment:
That will give us 3 duplicate methods.
I left a comment on refactoring. Maybe we can come back to this when
implementing streaming partial combiner (i.e., combining ReduceFn)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
