johnyangk commented on a change in pull request #172: [NEMO-270] Test different
triggers in GroupByKeyAndWindowDoFnTransformTest
URL: https://github.com/apache/incubator-nemo/pull/172#discussion_r238537290
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
##########
@@ -351,12 +343,17 @@ public TimerInternals timerInternalsForKey(final K key) {
public void emit(final WindowedValue<KV<K, Iterable<InputT>>> output) {
// adds the output timestamp to the watermark hold of each key
// +1 to the output timestamp because if the window is [0-5000), the
timestamp is 4999
- // TODO #270: consider early firing
- // TODO #270: This logic may not be applied to early firing outputs
- keyAndWatermarkHoldMap.put(output.getValue().getKey(),
- new Watermark(output.getTimestamp().getMillis() + 1));
+ if (output.getPane().getTiming().equals(PaneInfo.Timing.ON_TIME)) {
Review comment:
Can you add a brief comment on why we advance the output watermark for only
ON_TIME outputs?
Excluding LATE seems obvious (we don't want to advance 'backwards'), but
what about EARLY?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
