+1 (binding), but please look into Markus' feedback. Non-blocking comments: - Please add instruction header to the KEYS file (see example in Beam) - Examples parent module should go too?
Great work. On Thu, Dec 13, 2018 at 6:27 PM Markus Weimer <mar...@weimo.de> wrote: > I tried to build on Ubuntu 18.04 to check. On that platform, I am seeing > another issue: > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:javadoc (test-javadoc) > on project nemo-runtime-common: An error has occurred in Javadoc report > generation: > [ERROR] Exit code: 1 - > > /mnt/d/Downloads/incubator-nemo/runtime/common/target/generated-sources/protobuf/grpc-java/org/apache/nemo/runtime/common/comm/MessageServiceGrpc.java:23: > error: cannot find symbol > [ERROR] @javax.annotation.Generated( > [ERROR] ^ > [ERROR] symbol: class Generated > [ERROR] location: package javax.annotation > [ERROR] > [ERROR] Command line was: /usr/lib/jvm/java-11-openjdk-amd64/bin/javadoc > @options @packages > > This is very likely an issue with my setup, as I haven't compiled nemo > before... > > Consider me a +0 vote for now. > > Markus > > On Thu, Dec 13, 2018 at 5:54 PM Markus Weimer <mar...@weimo.de> wrote: > > > Hi, > > > > I tried `mvn clean test`on Windows 10, Java 1.8 and got the following > > error: > > > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on > > project nemo-conf: Execution validate of goal > > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed.: > > NullPointerException -> [Help 1] > > > > Is this expected? > > > > Thanks, > > > > Markus > > > > On Wed, Dec 12, 2018 at 9:09 PM 송원욱 <won...@apache.org> wrote: > > > >> +1 > >> > >> Build success on JDK 1.8 and Mac OS 10.14.1 (Mojave). > >> Wonook > >> > >> > >> 2018년 12월 12일 (수) 오전 6:11, Byung-Gon Chun <bgc...@gmail.com>님이 작성: > >> > >> > Mentors, could you take a look? > >> > > >> > Thanks! > >> > -Gon > >> > > >> > > >> > On Tue, Dec 11, 2018 at 5:58 PM Byung-Gon Chun <bgc...@gmail.com> > >> wrote: > >> > > >> > > +1 (binding) > >> > > > >> > > I checked the signature and digests. > >> > > "mvn clean install" passed on JDK 1.8/Mac OS 10.14.1. > >> > > > >> > > Thanks a lot, Joo Yeon! > >> > > - Gon > >> > > > >> > > > >> > > On Tue, Dec 11, 2018 at 4:26 PM Taegeon Um <taegeo...@gmail.com> > >> wrote: > >> > > > >> > >> +1 > >> > >> > >> > >> Build success on Ubuntu 16.04.5 LTS > >> > >> > >> > >> Best, > >> > >> Taegeon > >> > >> > >> > >> > On 11 Dec 2018, at 4:07 PM, Gyewon Lee <strayyy...@gmail.com> > >> wrote: > >> > >> > > >> > >> > +1 > >> > >> > > >> > >> > I verified the md5 & sha512 checksums and others. The candidate > was > >> > >> > successfully built on my MacBook Pro either (Mac OS Mojave > >> 10.14.1). > >> > >> > > >> > >> > Best, > >> > >> > Gyewon > >> > >> > > >> > >> > 2018년 12월 11일 (화) 오후 3:38, Sanha Lee <sanhaleeh...@gmail.com>님이 > >> 작성: > >> > >> > > >> > >> >> +1 > >> > >> >> > >> > >> >> I verified the checksum, PGP signature, release hash, and tag. > >> > >> >> `git diff` shows some difference between the release candidate > >> files > >> > >> and > >> > >> >> the repository files, but it was just about the file access > >> > >> permissions. > >> > >> >> Also, the candidate was successfully built on my MacBook Pro > (High > >> > >> Sierra > >> > >> >> 10.13.3). > >> > >> >> > >> > >> >> Best, > >> > >> >> Sanha > >> > >> >> > >> > >> >> 2018년 12월 11일 (화) 오후 2:48, Jangho Seo <jan...@apache.org>님이 작성: > >> > >> >> > >> > >> >>> Sorry, my vote is not a binding one. > >> > >> >>> > >> > >> >>> From the Incubator guide: > >> > >> >>> > >> > >> >>>> The only time when a PPMC member’s vote is binding is for the > >> > >> addition > >> > >> >>> of new PPMC members and committers. Release votes are only > >> binding > >> > to > >> > >> >>> IPMC members. > >> > >> >>> > >> > >> >>> Cheers, > >> > >> >>> Jangho > >> > >> >>> > >> > >> >>> On 12/11/18 2:43 PM, Jangho Seo wrote: > >> > >> >>>> +1 (binding) > >> > >> >>>> > >> > >> >>>> I checked the checksum, signature, and the difference with the > >> > tagged > >> > >> >>>> source tree and they looks all good to me. > >> > >> >>>> The source builds successfully with tests and performs well on > >> YARN > >> > >> >>>> cluster of 18 nodes. > >> > >> >>>> > >> > >> >>>> Again, thanks Joo Yeon for the works. > >> > >> >>>> > >> > >> >>>> Cheers, > >> > >> >>>> Jangho > >> > >> >>>> > >> > >> >>>> On 12/11/18 1:23 PM, Joo Yeon Kim wrote: > >> > >> >>>>> Hi Jangho, > >> > >> >>>>> > >> > >> >>>>> Could you check if it's gzipped once again? > >> > >> >>>>> > >> > >> >>>>> Thanks, > >> > >> >>>>> Joo Yeon > >> > >> >>>>> > >> > >> >>>>> On Tue, Dec 11, 2018 at 1:10 PM Jangho Seo < > jan...@apache.org> > >> > >> wrote: > >> > >> >>>>> > >> > >> >>>>>> Hi Joo Yeon. > >> > >> >>>>>> > >> > >> >>>>>> I see apache-nemo-0.1-incubating-rc2.tar.gz is not gzipped. > >> > >> >>>>>> What can we do to continue our release process? > >> > >> >>>>>> > >> > >> >>>>>> By the way, thanks for the hard work. > >> > >> >>>>>> > >> > >> >>>>>> Cheers, > >> > >> >>>>>> Jangho > >> > >> >>>>>> > >> > >> >>>>>> On 12/11/18 12:44 PM, Joo Yeon Kim wrote: > >> > >> >>>>>>> Hello Nemo PPMC, > >> > >> >>>>>>> > >> > >> >>>>>>> This is a call for the vote to approve the release, 0.1, > >> release > >> > >> >>>>>> candidate > >> > >> >>>>>>> 2. > >> > >> >>>>>>> Since release candidate 1, I have: > >> > >> >>>>>>> - Excluded examples/beam and examples/spark JARs from the > >> maven > >> > >> >>> artifact > >> > >> >>>>>>> being published. > >> > >> >>>>>>> - Added a checkstyle for Apache license headers > >> > >> >>>>>>> - Removed the platform dependent CRLF character from source > >> tar > >> > >> >> ball. > >> > >> >>>>>>> - Included a few other PRs that have been merged in the > >> > meanwhile. > >> > >> >>>>>>> > >> > >> >>>>>>> Please refer to the information below to vote on this > >> release, > >> > and > >> > >> >>> vote: > >> > >> >>>>>>> > >> > >> >>>>>>> [ ] +1 Release this package as Apache Nemo (incubating) 0.1 > >> > >> >>>>>>> [ ] 0 I don't feel strongly about it, but the release seems > >> > okay. > >> > >> >>>>>>> [ ] -1 Please do not release this package because... > >> > >> >>>>>>> > >> > >> >>>>>>> 1. Source release files: > >> > >> >>>>>>> > >> > >> >> > >> > https://dist.apache.org/repos/dist/dev/incubator/nemo/0.1-incubating/ > >> > >> >>>>>>> > >> > >> >>>>>>> 2. The release tag: > >> > >> >>>>>>> * > >> > >> >>>>>> > >> > >> >>> > >> > >> >> > >> > >> > >> > > >> > https://github.com/apache/incubator-nemo/releases/tag/apache-nemo-0.1-incubating-rc2 > >> > >> >>>>>>> < > >> > >> >>>>>> > >> > >> >>> > >> > >> >> > >> > >> > >> > > >> > https://github.com/apache/incubator-nemo/releases/tag/apache-nemo-0.1-incubating-rc2 > >> > >> >>>>>>> * > >> > >> >>>>>>> > >> > >> >>>>>>> 3. The release hash: > >> > >> >>>>>>> * > >> > >> >>>>>> > >> > >> >>> > >> > >> >> > >> > >> > >> > > >> > https://github.com/apache/incubator-nemo/commit/3ce6d20fd00f3bed690516abb24475d38edeff16 > >> > >> >>>>>>> < > >> > >> >>>>>> > >> > >> >>> > >> > >> >> > >> > >> > >> > > >> > https://github.com/apache/incubator-nemo/commit/3ce6d20fd00f3bed690516abb24475d38edeff16 > >> > >> >>>>>>> * > >> > >> >>>>>>> > >> > >> >>>>>>> 4. The Nexus Staging URL: > >> > >> >>>>>>> * > >> > >> >>> > >> > >> > >> https://repository.apache.org/content/repositories/orgapachenemo-1003/ > >> > >> >>>>>>> < > >> > >> >>> > >> > >> > >> https://repository.apache.org/content/repositories/orgapachenemo-1003/ > >> > >> >>>>>>> * > >> > >> >>>>>>> > >> > >> >>>>>>> 5. The KEYS file: > >> > >> >>>>>>> https://dist.apache.org/repos/dist/dev/incubator/nemo/KEYS > >> > >> >>>>>>> > >> > >> >>>>>>> > >> > >> >>>>>>> Best, > >> > >> >>>>>>> Joo Yeon > >> > >> >>>>>>> > >> > >> >>> > >> > >> >> > >> > >> > >> > >> > >> > > > >> > > -- > >> > > Byung-Gon Chun > >> > > > >> > > >> > > >> > -- > >> > Byung-Gon Chun > >> > > >> > > >
