By merging the PR I am now responsible for the code. That is how it works in Apache, right?
HTML/Java API doesn't get many PRs, I was glad to found this one. I know nothing about bd2019us either, but the code change was trivial, so I saw no technical reasons to reject it. I believe I'll be able to sustain the code in the future. -jt Dne neděle 21. dubna 2019 9:01:25 CEST, Matthias Bläsing napsal(a): > Hello all, > > the first PR from an external author was merged, that I would have > plainly rejected. > > https://github.com/apache/incubator-netbeans-html4j/pull/17 > > The most important reason is the missing author information. I don't > know who bd2019us is, but neigther his/er email adress, nor the name > convey any real name information. > > While the above PR is trivial in its nature and obvisouly correct, I > propose not to merge anymore PRs without valid author credits. It was > established, that we can merge PRs from non-committers, if we can > assume, that the change is either trivial or the author donated the > code. > > The other reason ist, that the author also does not react to replies > and thus I don't see any option to improve the situation, other than > just rejecting his/her PRs. > > As a final point: Please all check your author credentials, that they > are containing a valid real name part and a working email address. > > Greetings > > Matthias > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
