Hi Brad,
The process seems indeed correct. What we usually do is to run tests
(ant test), making sure we don't break anything.
After that one follows whatever the rest of the Team wants to add in the
comments in the PR.
For big contributions we may ask for an ICLA.
Thanks for your contribution!
Antonio
El 7/5/19 a las 21:23, Brad Walker escribió:
I'm trying to help out in a very small way. What I'm hoping to do is clean
up some of the build cruft and learn at the same time.
So I created a new Jira ticket for my work..
https://issues.apache.org/jira/browse/NETBEANS-2514
Made the changes to remove the usage of sun.misc.Unsafe in the
NoJavacHelper.java file.
And issued a pull request.
https://github.com/apache/netbeans/pull/1236
So a couple of things, I think this is the proper process to follow,
correct?
Also, since we only support the use of JDK 1.8 to compile Apache NetBeans,
I think this change is correct.. I really didn't want to add any logic.
Only to remove the usage of sun.misc.Unsafe.
Any suggestions and/or comments are appreciated.
-brad w.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
