Hi,

This looks great! Was going to comment on one of the PR but I've only had a
chance to glance at the code so far. A query ...

On Sat, 1 Jun 2019, 17:23 Eirik Bakke, <[email protected]> wrote:

> For now, I've kept the ImageUtilities API the same as before.
>

I'm somewhat -1 to the SVGLoader SPI approach checking by extension I
think. Why not a generic IconLoader SPI and first loader that handles the
URL wins? This allows other extension in future, for which I can think of a
few uses, and removes handler specific logic.

Best wishes,

Neil

>

Reply via email to