But tbh these disturbing clutter commits are only one part of the story. What developers sometimes don't see that references to external systems are important. But more important would be to create meaningful and describing commit messages. Because especially for long running software products issue tracking and planning tools are going to change so references in commits are less valuable then describing the problem within the commit.
-- Thanks Benjamin On 2019-11-20 21:38, Matthias Bläsing wrote:
Hi, Am Mittwoch, den 20.11.2019, 15:31 -0500 schrieb Tim Boudreau:On Wed, Nov 20, 2019 at 2:36 PM Benjamin Asbach <netbe...@impl.it> wrote:> So why > having these information in project history when it does not deliver any > additional value? >Because the point of developing software is to develop software, not pleasehypothetical future historians.this is shortsighted. I had the misfortune to have to sift through layers of changes. And I was happy, that the authors were resonably disciplined. The commits were mostly sane and the commit message carried value. While git diff is nice, a few months after a change, you can't reconstruct which commits belonged together. Yes I think it is valuable to produce a clean history. Not because I'm egocentric, but because I expect others to read my code, just as I read theirs and what applies to comments also applies to commit messages and history: You most probably write them also for yourself, so that you know why you did something a year or ten ago. For a project, that ask for code review I find an unclean history totally unhelpful - cleaning up your work also helps reflecting it and making it easier for others to understand. So if you think this is egocentric or something, I don't care to much, I clean up my work, I appretiate author creating a clean PR and I also do the work to cleanup others. Greetings Matthias --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
0xDBDA3F83.asc
Description: application/pgp-keys
signature.asc
Description: OpenPGP digital signature