On Thu, 21 Nov 2019 at 20:25, Geertjan Wielenga <[email protected]> wrote: > But haven't they been reviewed already? At this point, you can merge them > and continue with the process you describe of suggesting a signing option.
Theoretically there's an open request for review from Jan on the nb-javac one, and an open question on the other whether it's worth cherry picking (confirmation we can update that via NBM). Although both probably fine to merge to master. After merging to master, we need 3 more PRs made (ideally by the original authors*) on top of release112 to cherry pick the relevant commits and add others such as release branch spec version increment. Then they can be reviewed and I can merge and get on with other steps. * IMO original author is best placed to cherry pick, update and build an NBM to test in the release and make sure the fix applies correctly. I can do the RM steps next week, but if it slips into December then work commitments mean someone else will have to pick it up. Likewise, if someone wants to suggest alternative steps or handle the RM'ing now, please go ahead! There was also an alternative question about an Oracle signed nb-javac update that wasn't answered, although that doesn't address the other bugs. Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
