Yes. The plugin contains the Darcula LaF from JetBrains as an external
library, and some plumbing code that addresses the glitches and NetBeans
specific things when it is used in the IDE.
See it yourself:
https://github.com/Revivius/nb-darcula/tree/master/src/main/java/com/revivius/nb/darcula
Theoretically it won't be hard to apply the same concept to FlatLaF,
just having it build and selectable as a LaF in the IDE, then let the
community iron out the glitches.
On 11/22/19 3:09 PM, Eirik Bakke wrote:
Makes sense.
If I understand correctly, Hamit's Darcula NetBeans plugin is not a complete Swing LAF by itself,
but rather the NetBeans-related registrations and extensions needed to adapt IntelliJ's
"Darcula LAF" for the NetBeans IDE. This kind of "adapter" code would be needed
even if we were to use FlatLaF as the underlying Swing LAF. Thus I suspect that Hamit's code would
be a useful starting point even if the goal was to use FlatLaf as a base Swing LAF.
(And visually, I think FlatLaf looks great, too.)
Once an "official" dark theme is integrated into the NetBeans project, I can
help install HiDPI icons for the NetBeans window system, like I did for the Windows and
MacOS LAFs ( https://github.com/apache/netbeans/pull/859 ).
-- Eirik
-----Original Message-----
From: Laszlo Kishalmi <laszlo.kisha...@gmail.com>
Sent: Friday, November 22, 2019 5:37 PM
To: dev@netbeans.apache.org
Subject: Re: Current state of Oracle donation of NetBeans to Apache
Yes. Geertjan and me briefly talked with Hamit about that.
Hamit got quite busy recently, so I've done an extra step to prepare a branch
for him, so he only needs to fork that branch then create a PR to the official
NetBeans repo. So that PR would indicate his willingness of donation.
We could bug Hamit a few more times for sure, however I'd also consider other
plans to have a decent dark LaF, like https://www.formdev.com/flatlaf/
The fact Darcula LaF as it is is aging, some fixes need to be added, new
colors, etc. BTW probably that's true for Dark metal and Dark Nimbus as well.
We either get it donated so we can maintain it or just move on.
On 11/22/19 2:15 PM, Eirik Bakke wrote:
Ah, I see. Has there been any talk yet about getting the Darcula plugin itself
donated into NetBeans?
-- Eirik
-----Original Message-----
From: Laszlo Kishalmi <laszlo.kisha...@gmail.com>
Sent: Friday, November 22, 2019 4:55 PM
To: dev@netbeans.apache.org
Subject: Re: Current state of Oracle donation of NetBeans to Apache
The Darcula LaF has one file copied completely over (probably to overcome the
module friendship issues) from the NB dark LaF.
So it is more a licensing issue than a technical one.
On 11/22/19 1:42 PM, Eirik Bakke wrote:
What's the relationship between the Darcula NetBeans LAF plugin and the "dark theme
support"?
If the Darcula plugin depends on "dark theme support", and dark theme support
has not yet been donated--how come the Darcula plugin seems to work?
Eirik
-----Original Message-----
From: Laszlo Kishalmi <laszlo.kisha...@gmail.com>
Sent: Wednesday, September 11, 2019 11:13 PM
To: dev@netbeans.apache.org
Subject: Re: Current state of Oracle donation of NetBeans to Apache
Hi Geertjan,
I know it is a minor point, but were you successful to schedule the dark theme
support ahead from the last donation?
Darcula is kind of depending on that one, though maybe one or two classes form
them.
On 9/11/19 1:02 AM, Geertjan Wielenga wrote:
Hi all,
Long-ish e-mail on current status, with helpful headers in between.
*4th Donation*
The 4th donation, focused primarily on C/C++ support has gone
through auditing and we're satisfied that what we're donating to
Apache from Oracle really is Oracle's to donate. The source code is
now in a ZIP file at Oracle Legal, after which documents need to be
signed, and then the 4th donation will be complete and the code handed over to
Apache.
The o.n.swing.laf.dark mlodule is also included in the 4th donation.
This will be done soon but not soon enough to be included in the
11.2 release -- since aside from donating the code, there'll be
quite some work of relicensing everything to Apache and getting
everything to work correctly within Apache NetBeans. It looks to me
like the 11.3 release, scheduled for January[1] should be able to
include the C/C++ features, assuming the donation and integration is complete
in that timeframe.
*5th Donation*
After that is the 5th donation, which will focus on the clusters
nb.cluster.dlight and nb.cluster.extra. The C/C++ modules have a
build-time dependency on nb.cluster.dlight so until the 5th donation
is done, we'll need to depend on a binary at build time of the
relevant parts of that cluster. Included in this donation will be
the source code of the Jira module, as requested on this mailing list.
*Contrib Repository*
In parallel, there's the question of the 'contrib' cluster. Some of
the modules in there were experimental plugins written by Oracle
employees while others are under the OCA (Oracle Contributor
Agreement) by external third party contributors. The latter should
probably simply be able to donate their modules to Apache NetBeans,
without Oracle needing to be involved in any way. However, we're
getting Oracle Legal opinion on this, just to be sure. And we
probably don't want all of the contrib repository anyway, some clear guidance
from the community here would help.
*And then...*
After the above have been handled, the question is what to deal with
next, if anything.
We have these listed for donation but the question is whether anyone
is waiting for these or actually going to be working on them:
nb.cluster.javacard
nb.cluster.mobility
community-ruby
community-soa
community-uml
community-visualweb
What is the level of interest in the above areas of NetBeans? If
you're going to write in response "we must really have this in Apache NetBeans"
will you also be the one driving that code forward, adding new
features, and fixing related bugs yourself?
The transition page[2] has been updated to reflect the above.
[1]
https://cwiki.apache.org/confluence/display/NETBEANS/Release+Schedul
e
[2]
https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transiti
o
n
Thanks,
Gj
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
