Hi Laszlo, that was quick! Also had a glimpse to what Karl from FormDev is cooking up in his next PR and I am impressed!
Greetings, Alex Il giorno mar 10 dic 2019 alle ore 21:20 Laszlo Kishalmi < [email protected]> ha scritto: > And now it ison the way to master: > https://github.com/apache/netbeans/pull/1769 > > On 12/10/19 11:46 AM, Alessandro wrote: > > Hi Laszlo, > > please have a look at PR-1768. > > > > Greetings, > > Alex > > > > Il giorno dom 8 dic 2019 alle ore 20:48 Laszlo Kishalmi < > > [email protected]> ha scritto: > > > >> Check out the branch from the apache repo, then commit it back to your > >> fork, that would be fine. and yes then the PR > >> > >> > >> On 12/8/19 11:23 AM, Alessandro wrote: > >>> Hi Laszlo, > >>> I had a quick look to your work and I saw that we made similar > choices > >>> with regard to file naming and folder structure. I did not use your > >>> upgraded DTD for defining the color palette but this can be worked on > >>> afterwards. The NBDarcula color profiles define colours with an ARGB > hex > >>> color notation, does your new DTD suppor that? > >>> > >>> How should I proceed considering that I cannot commit to the Apache > >>> repository directly? Is it OK if I fork again the repo, checkout your > >>> branch, update it and then open a PR against your original branch? > >>> > >>> Let me know. > >>> > >>> Greetings, > >>> Alex > >>> > >>> Il giorno dom 8 dic 2019 alle 19:55 Laszlo Kishalmi < > >>> [email protected]> ha scritto: > >>> > >>>> The branch name is: flatlaf-fontscolors > >>>> > >>>> I'd name the theme to FlatLaf Dark and we probably improve it a bit > over > >>>> Darcula. > >>>> > >>>> Let's keep the name Darcula for the external nb-darcula plugin. > >>>> > >>>> On 12/8/19 10:48 AM, Laszlo Kishalmi wrote: > >>>>> Huh, I kind of worked on the same thing. > >>>>> > >>>>> Let me open a branch for that. I'd put the basic files and layout > >>>>> there. You can update the content as that's I'm not finished with. > >>>>> Then once we put our stuff together we create a PR from that branch. > >>>>> > >>>>> As of the Norway Today. I think it is either was available before the > >>>>> Dark Look and Feels. It is a similar theme like IBM used in OS/2 E > >>>>> editor (an old time favorite of mine from 1998). I used it a lot even > >>>>> with light LaF-s. > >>>>> > >>>>> > >>>>> On 12/8/19 9:50 AM, Alessandro wrote: > >>>>>> Hi all, > >>>>>> I have created an editor color profile that matches the Darcula > >>>>>> palette > >>>>>> by porting the NB Darcula color profile. > >>>>>> > >>>>>> I have called this new profile "FlatLafDark" and put it into > >>>>>> platform/o.n.swing.laf.flatlaf in my fork of Apache NetBeans source, > >>>>>> however I noticed that the standard color profiles (e.g. Norway > >>>>>> Today, City > >>>>>> Lights, etc.) live in ide/defaults. It also seems a bit strange that > >>>>>> they > >>>>>> are in different clusters. > >>>>>> > >>>>>> Moreover I noticed that the recently ported dark LAFs (Dark Metal > and > >>>>>> Dark > >>>>>> Nimbus) are not tightly coupled with a color profile but suggest the > >>>>>> use of > >>>>>> Norway Today as recommended profile (recent work by Laszlo Kishalmi > in > >>>>>> commit > >>>>>> > >> > https://github.com/apache/netbeans/commit/f268b73e83b4d10e3c015a5fee2c7e8adc258237 > >> ) > >>>>>> thus it could be better to choose a generic name for the color > >>>>>> profile such > >>>>>> as "Darcula". > >>>>>> > >>>>>> How should I call the new color profile and where should I place its > >>>>>> files? > >>>>>> > >>>>>> Regards, > >>>>>> Alex > >>>>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: [email protected] > >>>> For additional commands, e-mail: [email protected] > >>>> > >>>> For further information about the NetBeans mailing lists, visit: > >>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > >>>> > >>>> > >>>> > >>>> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> For further information about the NetBeans mailing lists, visit: > >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > >> > >> > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
