Yes, if there is more activity in those pull request discussions, we can get it done the right way.
Gj On Fri, 21 Feb 2020 at 19:36, Ernie Rael <[email protected]> wrote: > On 2/21/2020 10:20 AM, Geertjan Wielenga wrote: > > I’d be pretty much against forking Gluon. > > I understand. But it looks like that approach leaves NB-12 without > working javafx maven NewProject. Whereas with a fork and a small amount > of work we can fix it. > > > > > The best you can do, I think, is join in on those Gluon pull request > > discussions. > > We disagree. I believe the best I can do is getting it to work in NB-12. > Little work, big gain. Trivial to go back to gluon when their archetype > and NB API are ready. > > Do you see getting Gluon to change there stuff *and* implementing the > API change as possible for NB-12? > > -ernie > > > > > Gj > > > > On Fri, 21 Feb 2020 at 18:22, Ernie Rael <[email protected]> wrote: > > > >> On 2/21/2020 8:46 AM, Geertjan Wielenga wrote: > >>> Note that Gluon doesn't want your nbactions.xml file, logically, > because > >>> their sample projects are applicable to any IDE or non-IDE and > >>> nbactions.xml is NetBeans specific. Hence this is something that must > be > >>> handled on the NetBeans side. > >>> > >>> Unless what you're looking to do is to fork the Gluon samples, not sure > >> if > >>> that is desirable, would be best for NetBeans to leverage the official > >>> Gluon samples and not a fork, so that we can continue benefiting from > >>> enhancements made by the Gluon team to the official samples. > >> > >> Yes, I'm suggesting fork the two Gluon samples; these samples are > >> trivial and not meant for an IDE (no debug). The idea is too have a bare > >> bones project that works out of the box. Those New project actions are > >> part of NB source code, not some Gluon plugin; they give a terrible user > >> experience. > >> > >> If in the future, gluon comes up with something usable, then it's a > >> trivial change in NB source to reference their new maven artifact. > >> > >> It's worth noting that if Gluon should fix up their samples, it won't > >> matter until the next NB release since the artifact id is compiled into > NB. > >> > >> As far as benefiting from enhancements, those pull requests you mention > >> have been around for over 5 months. NB should have a working project out > >> of the box, and there's not much time left to get something for NB-12. > >> > >> To get something working, the options seem to be 1) get gluon to change > >> their archetypes, make some NB API changes, modify NB source to use the > >> new API; 2) reference a different archetype. > >> > >> 2) is almost no work; 1) can it make it into nb-12? > >> > >> -ernie > >> > >>> Gj > >>> > >>> On Fri, Feb 21, 2020 at 5:41 PM Geertjan Wielenga <[email protected] > > > >>> wrote: > >>> > >>>> https://github.com/openjfx/javafx-maven-archetypes/pull/6 > >>>> https://github.com/openjfx/javafx-maven-archetypes/pull/8 > >>>> > >>>> Gj > >>>> > >>>> > >>>> > >>>> On Fri, Feb 21, 2020 at 5:28 PM Ernie Rael <[email protected]> > wrote: > >>>> > >>>>> Currently NewProject>JavaWithMaven>...JavaFXMavenArchetype... > creates a > >>>>> project that doesn't just work. See > >>>>> https://issues.apache.org/jira/browse/NETBEANS-3730 and > >>>>> https://issues.apache.org/jira/browse/NETBEANS-3104 . > >>>>> > >>>>> Generally, the problem is attributed to missing nbactions.xml, but > >> there > >>>>> is also the problem that the pom.xml doesn't support running a > >> debugger. > >>>>> I've modified the gluon archetype generator to provide a nbactions > and > >>>>> pom that fixes these problems. Run and debug work out of the box. > >>>>> > >>>>> Can this be published to maven central and used by NB's new project? > I > >>>>> guess the main issue is finding a home for the source/maven-GroupId > >>>>> > >>>>> -ernie > >>>>> > >>>>> > >>>>> --------------------------------------------------------------------- > >>>>> To unsubscribe, e-mail: [email protected] > >>>>> For additional commands, e-mail: [email protected] > >>>>> > >>>>> For further information about the NetBeans mailing lists, visit: > >>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > >>>>> > >>>>> > >>>>> > >>>>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> For further information about the NetBeans mailing lists, visit: > >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > >> > >> > >> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
