Okay...I'm trying to do so (would be my first push by the way), but I think my git/github PR inexperience may be coming in to play here...
This is I believe for https://github.com/apache/netbeans/pull/2007 or more specifically https://github.com/apache/netbeans/pull/2007/commits/5e7ce9bb83e73801b48c2261c170b91fb889eb0b but I seem to have extra "commits" included with the PR that I didn't mean to include in any way. Over time I've creating "commits" on my fork to keep up to date with changes against the master apache/netbeans fork and now they shows all those extra commits. I'm not sure how to exclude all those and just have the one commit with the actual changes and avoid polluting the history with those (which were already covered by the original submitters) I assume this is a "rebase" or "squash" type action needed to be done but I'm not sure how to do that with github. Eric Bresie [email protected] On Sat, Mar 7, 2020 at 10:34 AM Geertjan Wielenga <[email protected]> wrote: > That message appears automatically when you try to build with a JDK later > than 8, though you’re welcome to provide a pull request here: > > https://github.com/apache/netbeans/blob/master/README.md > > Gj > > On Sat, 7 Mar 2020 at 17:24, Eric Bresie <[email protected]> wrote: > > > Okay...I was trying to rebuild recent master and was reading the readme > and > > remembered that to compile on newer JDKs, the need for a compilation > > parameter to be passed to the ant build. > > > > In the past I've always had to dig through emails to remember what this > > parameter was which allowed me to build, > > > > However I was wondering if this could be added to the readme.md (maybe > with > > the "Notes" following the build ant context) to provide some additional > > notes on more advanced build options. > > > > "It is possible to compiled with new JDK versions, but this requires > > inclusion of the ' -Dpermit.jdk9.builds=true' parameter to be added at > > buikd time" > > > > I was also curious if beyond this one parameter, if there might be other > > similar parameters of interest that could be added (not familiar with all > > of them but assume there ould be stuff like jdkhome type parameters, > etc). > > > > Does this sort of change require a jira issue to be raised? > > > > Eric Bresie > > [email protected] > > >
