On Tue, 17 Mar 2020 at 23:37, Eirik Bakke <[email protected]> wrote: > My personal policy is to do everything through GitHub PRs, except trivial > changes in code that I originally wrote myself. (I wrote the SVG loader > module in this case.)
IMO we should not be doing straight push to the repo whether inside or outside freeze periods, except for a very limited number of cases (security, etc.) where review must obviously be private. Bypassing PRs also bypasses review processes, some archiving and pre-merge testing. Even the entire release process (aside from tags) is done via PR now. I personally have push-url on the upstream set to DISABLED for this reason and use the full git URL for pushing tags (should anyone wonder at the mention of this in the wiki docs on releases). Inside freeze, obviously the release manager needs to be aware of, if not actively merging, every change. Be glad it's Eric - he's more chilled than I am! ;-) Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
