Hi, there is a comment from Neil that should be reviewed I guess. Regards Eric
-----Message d'origine----- De : Geertjan Wielenga <geert...@apache.org> Envoyé : lundi 20 avril 2020 10:46 À : dev@netbeans.apache.org Objet : Re: Not installing nb-javac unasked: important for 12.0 Beta 4 That’s the expected behavior, right? Gj On Mon, 20 Apr 2020 at 03:49, Mark Eggers <its_toas...@yahoo.com.invalid> wrote: > Environment: > OS: Windows 10 Professional 64 bit latest patches > JDK: OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.6+10) > OpenJDK Runtime Environment (AdoptOpenJDK)(build > 1.8.0_252-b09) > > Building with this PR (https://github.com/apache/netbeans/pull/2062) > on both JDK 11 and JDK 8 results in the following: > > Running the JDK 8 build on JDK 8 prompts for the installation of > nb-javac (as expected). Without installing nb-javac, various Java > Plugins cannot be activated. > > Running on JDK 11 allows the activation of all plugins for both the > JDK > 8 and JDK 11 builds without installing nb-javac. There is a > notification stating that nb-javac is strongly recommended for > advanced Java editing and compile on save features. > > . . . just my two cents. > /mde/ > > On 4/19/2020 1:57 PM, Geertjan Wielenga wrote: > > Below is the pull request enabling nb-javac to not be installed unasked. > > > > Eric, can this be included in Beta 4? > > > > Gj > > > > On Sat, 18 Apr 2020 at 13:41, Geertjan Wielenga > > <geert...@apache.org> > wrote: > > > >> Hi all, especially Eric, > >> > >> Let's not forget to include this one: > >> > >> https://github.com/apache/netbeans/pull/2062 > >> > >> Thanks, > >> > >> Gj > >> > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
