Hi, Thanks for the reloging tip it allow me to retrigger the build. Hector, for the github action, maybe double check with Apache infra on their asf slack channel. They may have done one or yours can help other project. Would be nice to expose mail and name(it's only available to people logged and this information should be public )
Best Regards Eric -----Message d'origine----- De : Hector Espert <[email protected]> Envoyé : samedi 2 mai 2020 17:19 À : dev <[email protected]> Objet : Re: About NetBeans build quality Hi, About a pull request with an invalid mail or an invalid name. I've started experimenting with GitHub actions and I've created a simple action to check commit author name and email. Currently anly check if commit is not created using a GitHub private email, like [email protected] or if the name matches a regex. It is published in GitHub actions marketplace: https://github.com/marketplace/actions/check-author-name-and-email I've created a draft pr in the netbeans repo to test it: https://github.com/apache/netbeans/pull/212 Is there any objection to use GitHub actions for that? El sáb., 2 may. 2020 a las 0:57, Eric Barboni (<[email protected]>) escribió: > Hi, > > I agree with the big picture. But > > For what I encounter since 2 months I guess, travis job is not more > re triggerable (partial job too). > During 11.3 travis build had 1 download issue for 4 builds and was red > for no reason. So travis trust is low for me. > Travis Master build has the same testing rule that a PR build has ? > because it's green and the sync to release too. > > PR check doing only test is not enough. A pr with invalid mail, > invalid name should be flagged too before review code. It cost > Matthias hours :p Hector Espert do a lot of addition to travis test > but I'm unsure the coverage of travis test. > Best Regards > Eric > > -----Message d'origine----- > De : Neil C Smith <[email protected]> Envoyé : vendredi 1 mai 2020 > 12:23 À : dev <[email protected]> Objet : Re: About NetBeans > build quality > > On Fri, 1 May 2020 at 09:32, Benjamin Graf <[email protected]> wrote: > > IMHO we all should have a look and taking more care after our PRs > > being > green on Travis, too. Sometimes periodically rebasing against master > does help getting green again if build is broken because of Travis > bugs or someone else broken commits. > > +1 And sometimes just retriggering Travis gets things working - to > pick up fixes in master, and there are a few spurious failures at > times unfortunately. > > My general approach when RM'ing was all PRs must be green before > merging to master, the sync PR from master to release branch must be > green before merging, and the release branch must be green before > triggering a beta / release build. > > This isn't a criticism of Eric's work here because I think aspects of > the Travis tests have been broken for a while now. Be good to get > them back on track, ideally before considering 12.0 release. > > Best wishes, > > Neil > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
