No problem.. I try to keep my changesets to no more than 100-150 files when I have a large changeset.. Past that and my eyes start to glaze over..
Thanks everyone for the comments.. -brad w. On Mon, Jul 27, 2020 at 11:32 AM antonio <[email protected]> wrote: > Hi Brad, > > We prefer small changesets so pull requests are easier to review. Anyway > from time to time some abusers post PRs with 5k files [1] (we should > start punishing these somehow). > > Just proceed with the PR normally, as Neil suggests. We'll deal with it. > > Thanks & kind regards, > Antonio > > [1] https://github.com/apache/netbeans-website/pull/457 > > > El 27/7/20 a las 17:00, Brad Walker escribió: > > The ONLY reason I ask is that I'm doing a LOT of extremely simple changes > > like updating the license headers in a LOT of files. Also, I didn't want > to > > imply that I push directly to the CND branch.. I just was thinking it > would > > be helpful if I was able to commit my pull requests for license header > > changes. Hopefully, my intentions are more clean. > > > > I'm simply trying to keep the workload down for the committers. > > > > But, I can certainly continue on with the "pull reques and wait" model if > > that is preferable. > > > > -brad w. > > > > On Mon, Jul 27, 2020 at 9:52 AM Neil C Smith <[email protected]> > wrote: > > > >> On Mon, 27 Jul 2020 at 15:05, Brad Walker <[email protected]> wrote: > >>> > >>> I'm going to be checking in a lot of files that are license related for > >> the > >>> C/C++ CND module.. > >>> > >>> Would it be inappropriate to ask for GitHub access to help with this? I > >> can > >>> promise to only keep my check-ins to license related work on CND or > other > >>> restrictions the team decides.. > >>> > >>> Would this be a reasonable request? > >> > >> Why? Only ASF committers have write access to the repository. That > >> might be possible, but committers also rarely push to the repository > >> directly. Vast majority of updates are done via pull requests. Is > >> there a specific concern you have about putting in pull requests > >> against the CND branch? > >> > >> Best wishes, > >> > >> Neil > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
